[OSSM-8688] Ignore catatonit for kiali operator#242
[OSSM-8688] Ignore catatonit for kiali operator#242openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
config.toml
Outdated
| error = "ErrGoMissingTag" | ||
| dirs = ["/assets/downloads/cli"] | ||
|
|
||
| [[payload.openshift-istio-kiali-operator-container.ignore]] |
There was a problem hiding this comment.
Is this container image and binary present in all versions of OpenShift?
If not, we may want to consider adding it to the version specific configs in https://github.com/openshift/check-payload/tree/main/dist/releases - which is the approach used in https://github.com/openshift/check-payload/pull/223/files.
There was a problem hiding this comment.
@rhmdnd I don't know, I can update the PR to use the same as in #223 since we have that issue only due to the fact that we are using ansible-operator image as a base image for kiali operator.
(probably other teams that use the same base image see the same output as well and will need to add their image into the ignore list)
cc: @jmazzitelli
There was a problem hiding this comment.
Is this container image and binary present in all versions of OpenShift?
It should be. There are no versions of OpenShift where Kiali Operator is not supported.
There was a problem hiding this comment.
Ok - I appreciate the clarification. Thanks for breaking it out into the versioned configs.
There was a problem hiding this comment.
Why didn't we include this config for OCP 4.14 and OCP 4.15? AFAIK these OCP versions are to be supported by the Kiali operator.
|
/test images |
1 similar comment
|
/test images |
|
|
||
| [[payload.openshift-istio-kiali-operator-container.ignore]] | ||
| error = "ErrNotDynLinked" | ||
| files = ["/usr/libexec/catatonit/catatonit"] |
There was a problem hiding this comment.
Note for other reviews and historical reference. The catatonic binary is built statically, hence the exception here.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkralik3, rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mkralik3: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
Fips scanner reports
for our kiali operator image.
We use
ose-ansible-rhel9-operator:v4.17.0-202412170235as a base image for which it was resolved by #223 .I have added kiali operator to ignore list as well.