Skip to content

OCPBUGS-43103: skip ErrNotDynLinked for catatonit in ansible-operator#223

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
chiragkyal:catatonit-fix
Oct 16, 2024
Merged

OCPBUGS-43103: skip ErrNotDynLinked for catatonit in ansible-operator#223
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
chiragkyal:catatonit-fix

Conversation

@chiragkyal
Copy link
Member

Skip executable is not dynamically linked for /usr/libexec/catatonit/catatonit in ansible-operator

catatonit has to be a static binary, and as per Slack discussion, it does not perform any cryptographic operations.

https://pkgs.devel.redhat.com/cgit/rpms/catatonit/tree/catatonit.spec?h=rhel-9-main#n36

catatonit has to be a static binary and it does not perform any cryptographic operations
https://pkgs.devel.redhat.com/cgit/rpms/catatonit/tree/catatonit.spec?h=rhel-9-main#n36

Signed-off-by: chiragkyal <ckyal@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 16, 2024
@openshift-ci-robot
Copy link

@chiragkyal: This pull request references Jira Issue OCPBUGS-43103, which is invalid:

  • expected the bug to target only the "4.18.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Skip executable is not dynamically linked for /usr/libexec/catatonit/catatonit in ansible-operator

catatonit has to be a static binary, and as per Slack discussion, it does not perform any cryptographic operations.

https://pkgs.devel.redhat.com/cgit/rpms/catatonit/tree/catatonit.spec?h=rhel-9-main#n36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@chiragkyal chiragkyal marked this pull request as ready for review October 16, 2024 13:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@chiragkyal
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 16, 2024
@openshift-ci-robot
Copy link

@chiragkyal: This pull request references Jira Issue OCPBUGS-43103, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@chiragkyal
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@chiragkyal: This pull request references Jira Issue OCPBUGS-43103, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @KeenonLee

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from KeenonLee October 16, 2024 13:55
@chiragkyal
Copy link
Member Author

/test images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ashwindasr
Copy link
Contributor

ashwindasr commented Oct 16, 2024

Tested, excludes work as expected. Successful run reported

Copy link
Contributor

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0a209f2 into openshift:main Oct 16, 2024
@openshift-ci-robot
Copy link

@chiragkyal: Jira Issue OCPBUGS-43103: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43103 has been moved to the MODIFIED state.

Details

In response to this:

Skip executable is not dynamically linked for /usr/libexec/catatonit/catatonit in ansible-operator

catatonit has to be a static binary, and as per Slack discussion, it does not perform any cryptographic operations.

https://pkgs.devel.redhat.com/cgit/rpms/catatonit/tree/catatonit.spec?h=rhel-9-main#n36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@chiragkyal chiragkyal deleted the catatonit-fix branch October 16, 2024 20:16
Copy link
Member

@KeenonLee KeenonLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 25, 2024
@openshift-ci-robot
Copy link

@chiragkyal: Jira Issue OCPBUGS-43103 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

Skip executable is not dynamically linked for /usr/libexec/catatonit/catatonit in ansible-operator

catatonit has to be a static binary, and as per Slack discussion, it does not perform any cryptographic operations.

https://pkgs.devel.redhat.com/cgit/rpms/catatonit/tree/catatonit.spec?h=rhel-9-main#n36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants