Skip to content

fix: Type soundness issue with Provider.resolveObjectEvaluation #1158 #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScottVenkataraman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Type soundness issue with Provider.resolveObjectEvaluation #1158 #1361

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf831b
Set defaultValue and Promise ResolutionDetails to JsonValue
ScottVenkataraman Mar 6, 2026
2e7e723
remove T extends JsonValue type parameter from method definition
ScottVenkataraman Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/server/src/provider/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ export interface Provider extends CommonProvider<ServerProviderStatus> {
*/
resolveObjectEvaluation<T extends JsonValue>(
flagKey: string,
defaultValue: T,
defaultValue: JsonValue,
context: EvaluationContext,
logger: Logger,
): Promise<ResolutionDetails<T>>;
): Promise<ResolutionDetails<JsonValue>>;
}
Loading