fix(core): convert filePath to an absolute path before typescript resolves the module#34001
Merged
jaysoo merged 3 commits intonrwl:masterfrom Dec 29, 2025
Merged
fix(core): convert filePath to an absolute path before typescript resolves the module#34001jaysoo merged 3 commits intonrwl:masterfrom
jaysoo merged 3 commits intonrwl:masterfrom
Conversation
…olves the module Convert the filePath to an absolute path inside findProjectFromImport before calling resolveImportWithTypescript, because TypeScript’s module resolution will not correctly traverse up the directory tree toward the workspace root when given a relative path. closed nrwl#33985
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 0b710a2 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
qing-lin-007
changed the title
Contributor
|
View your CI Pipeline Execution ↗ for commit 02f3a32
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
Since the failure was identified as flaky, the solution is to rerun CI. Because this branch comes from a fork, it is not possible for us to push directly, but you can rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🎓 Learn more about Self-Healing CI on nx.dev
jaysoo
approved these changes
Dec 29, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
TypeScript’s module resolution stop at project's root when resolving modules.
Expected Behavior
TypeScript’s module resolution will walk up to the workspace root when resolving modules
Changes Made
Convert the filePath to an absolute path inside findProjectFromImport before calling resolveImportWithTypescript, because TypeScript’s module resolution will not correctly traverse up the directory tree toward the workspace root when given a relative path.
Related Issue(s)
Fixes #33985