fix: Fixes Kubernetes deployment crash on runtime_port parsing (#11968)

[Adam-Aghili]

• feat: add runtime port validation for Kubernetes service discovery

• test: add unit tests for runtime port validation in Settings

• fix: improve runtime port validation to handle exceptions and edge cases

Summary by CodeRabbit

• New Features

  • Enhanced runtime port configuration to accept multiple input formats, including Kubernetes service discovery URLs, numeric strings, and standard port URLs with automatic parsing and validation.

• Tests

  • Added comprehensive unit tests validating port configuration across various input scenarios and edge cases.

[coderabbitai]

Walkthrough

Added a pre-validation method to the Settings class that parses runtime_port values from string inputs, including Kubernetes-like formats (e.g., tcp://host:port), and normalizes them to integers or None. Includes comprehensive unit tests covering various input scenarios.

Changes

Cohort / File(s)	Summary
Settings Port Validator src/lfx/src/lfx/services/settings/base.py	Added validate_runtime_port field validator to parse port values from strings, URL-like formats, and Kubernetes env var patterns, returning integer port or None for unparseable inputs.
Port Validator Tests src/lfx/tests/unit/services/settings/test_runtime_port.py	Added new test module with 9 unit tests covering parsing of Kubernetes service discovery URLs, numeric strings, plain integers, out-of-range ports, non-numeric values, and missing ports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• fix: Fixes Kubernetes deployment crash on runtime_port parsing #11968: Adds the same validate_runtime_port field validator to Settings class with identical test coverage for parsing URL-like environment variables and extracting integer port values.

Suggested labels

bug

Suggested reviewers

• edwinjosechittilappilly
• jordanrfrazier

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 2 warnings)

Check name	Status	Explanation	Resolution
Test Coverage For New Implementations	❌ Error	Test coverage for validate_runtime_port is incomplete; missing critical boundary tests for out-of-range numeric strings and direct integer inputs identified in review.	Add missing test cases for out-of-range numeric strings (e.g., "99999") and direct integers, and update implementation to consistently enforce valid port bounds (1-65535) across all input types.
Test Quality And Coverage	⚠️ Warning	Test suite has critical gaps in boundary validation coverage for numeric string and direct integer inputs, allowing out-of-range ports to bypass validation.	Add test cases for out-of-range numeric string (99999) and direct integer (70000) inputs; fix validator to enforce 1-65535 range consistently for all input types.
Test File Naming And Structure	⚠️ Warning	Test file has incomplete edge case coverage for out-of-range plain numeric strings and direct integer inputs, as identified in review comments.	Add tests for out-of-range values (e.g., '99999', 70000) and update validator to enforce port bounds (1-65535) consistently across all input types.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing a Kubernetes deployment crash by improving runtime_port parsing, which matches the PR objectives and code changes.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Excessive Mock Usage Warning	✅ Passed	Tests use monkeypatch only for environment variables (external dependency) while instantiating real Settings objects to verify actual runtime_port parsing behavior, avoiding excessive mocking of core logic.

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch k8-crash

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Frontend Unit Test Coverage Report

Coverage Summary

Lines	Statements	Branches	Functions
	22.04% (7566/34320)	14.69% (3947/26855)	14.88% (1081/7261)

Unit Test Results

Tests	Skipped	Failures	Errors	Time
2507	0 💤	0 ❌	0 🔥	42.211s ⏱️

[codecov]

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.39%. Comparing base (d602738) to head (aec424a).
⚠️ Report is 1 commits behind head on release-1.8.0.

Files with missing lines	Patch %	Lines
src/lfx/src/lfx/services/settings/base.py	84.21%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           release-1.8.0   #11975      +/-   ##
=================================================
- Coverage          36.40%   36.39%   -0.02%     
=================================================
  Files               1570     1570              
  Lines              76655    76674      +19     
  Branches           11629    11635       +6     
=================================================
- Hits               27910    27904       -6     
- Misses             47169    47191      +22     
- Partials            1576     1579       +3     

Flag	Coverage Δ
backend	56.31% <ø> (-0.11%)	⬇️
frontend	19.80% <ø> (ø)
lfx	41.49% <84.21%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/lfx/src/lfx/services/settings/base.py	71.71% <84.21%> (+0.56%)	⬆️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/lfx/tests/unit/services/settings/test_runtime_port.py`:
- Around line 26-31: Add two edge-case tests for runtime port handling: extend
or add to test_runtime_port_from_integer_string to include a plain-numeric
out-of-range case (e.g., monkeypatch.setenv("LANGFLOW_RUNTIME_PORT","99999"))
and assert that Settings() raises the same validation error type your validator
uses (e.g., ValidationError or ValueError) for out-of-range ports; and add a
direct-int validation test that constructs Settings(runtime_port=7865) (or sets
runtime_port to an int) and asserts settings.runtime_port == 7865 to ensure
non-string integer inputs are validated consistently with the URL-parsing path;
reference the Settings class and the runtime_port attribute when locating where
to add these tests.

---

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 355c589 and aec424a.

📒 Files selected for processing (2)

• src/lfx/src/lfx/services/settings/base.py
• src/lfx/tests/unit/services/settings/test_runtime_port.py

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Enforce valid port bounds for numeric/int inputs.

Line 369 and Line 372 currently accept out-of-range numeric values (e.g., 99999) while URL-style values with the same port are rejected, so validation is inconsistent and can still leak invalid ports downstream.

🔧 Proposed fix

     `@field_validator`("runtime_port", mode="before")
     `@classmethod`
     def validate_runtime_port(cls, value):
@@
+        def _normalize_port(port: int) -> int | None:
+            return port if 1 <= port <= 65535 else None
+
         if value is None:
             return None
-        if isinstance(value, int):
-            return value
+        if isinstance(value, int) and not isinstance(value, bool):
+            return _normalize_port(value)
         if isinstance(value, str):
+            value = value.strip()
             if value.isdigit():
-                return int(value)
+                return _normalize_port(int(value))
             if "://" in value:
                 from urllib.parse import urlparse
@@
                 except ValueError:
                     return None
                 if parsed_port is not None:
-                    return parsed_port
+                    return _normalize_port(parsed_port)
         return None

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Add boundary tests for plain numeric inputs to match validator intent.

There’s no test asserting out-of-range handling for plain numeric inputs (e.g., "99999"), and no direct-int validation case. That gap would miss the current inconsistency versus URL parsing behavior.

🧪 Suggested additional tests

 def test_runtime_port_from_integer_string(monkeypatch):
@@
     settings = Settings()
     assert settings.runtime_port == 7865
+
+
+def test_runtime_port_from_out_of_range_integer_string_returns_none(monkeypatch):
+    """Out-of-range numeric string should fall back to None."""
+    monkeypatch.setenv("LANGFLOW_RUNTIME_PORT", "99999")
+    settings = Settings()
+    assert settings.runtime_port is None
+
+
+def test_runtime_port_from_direct_int_out_of_range_returns_none():
+    """Direct int input should also enforce valid TCP port range."""
+    settings = Settings(runtime_port=70000)
+    assert settings.runtime_port is None

As per coding guidelines, "Consider including edge cases and error conditions for comprehensive test coverage".

Also applies to: 61-79

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lfx/tests/unit/services/settings/test_runtime_port.py` around lines 26 -
31, Add two edge-case tests for runtime port handling: extend or add to
test_runtime_port_from_integer_string to include a plain-numeric out-of-range
case (e.g., monkeypatch.setenv("LANGFLOW_RUNTIME_PORT","99999")) and assert that
Settings() raises the same validation error type your validator uses (e.g.,
ValidationError or ValueError) for out-of-range ports; and add a direct-int
validation test that constructs Settings(runtime_port=7865) (or sets
runtime_port to an int) and asserts settings.runtime_port == 7865 to ensure
non-string integer inputs are validated consistently with the URL-parsing path;
reference the Settings class and the runtime_port attribute when locating where
to add these tests.