Skip to content

Revert "Remove Loadbalancer interface and use k8s-cloud-provider mocks"#783

Merged
k8s-ci-robot merged 1 commit intomasterfrom
revert-781-remove-lb-interface
Jun 24, 2019
Merged

Revert "Remove Loadbalancer interface and use k8s-cloud-provider mocks"#783
k8s-ci-robot merged 1 commit intomasterfrom
revert-781-remove-lb-interface

Conversation

@rramkumar1
Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 commented Jun 24, 2019

Reverts #781 as it was not finished yet.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 24, 2019
@bowei
Copy link
Copy Markdown
Member

bowei commented Jun 24, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@k8s-ci-robot k8s-ci-robot requested review from freehan and thockin June 24, 2019 19:49
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3827fef into master Jun 24, 2019
@bowei bowei deleted the revert-781-remove-lb-interface branch July 29, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants