Skip to content

Remove Loadbalancer interface and use k8s-cloud-provider mocks#781

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
spencerhance:remove-lb-interface
Jun 24, 2019
Merged

Remove Loadbalancer interface and use k8s-cloud-provider mocks#781
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
spencerhance:remove-lb-interface

Conversation

@spencerhance
Copy link
Copy Markdown
Contributor

@spencerhance spencerhance commented Jun 21, 2019 •
edited
Loading

This requires some new common hooks in k8s-cloud-provider, PR: GoogleCloudPlatform/k8s-cloud-provider#16 and pulling in those changes to vendor

Used #340 as a reference.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 21, 2019

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 21, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and freehan June 21, 2019 03:05
@spencerhance spencerhance force-pushed the remove-lb-interface branch from b68b89a to a43d2e2 Compare June 21, 2019 06:13
@rramkumar1
Copy link
Copy Markdown
Contributor

rramkumar1 commented Jun 21, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2019
@spencerhance spencerhance mentioned this pull request Jun 22, 2019
Merged
bowei
bowei reviewed Jun 23, 2019
View reviewed changes
pkg/loadbalancers/loadbalancers_test.go Outdated
Copy link
Copy Markdown
Member

@bowei bowei Jun 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mock := fakeGCE.Compute().(*cloud.MockGCE)

makes the code below less verbose

Copy link
Copy Markdown
Member

@bowei bowei Jun 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or better yet, keep a pointer to mock in testJig (e.g. j.mock) as it is used all the time

Copy link
Copy Markdown
Contributor Author

@spencerhance spencerhance Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

bowei
bowei reviewed Jun 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/ok-to-test

mostly looks good

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2019
@rramkumar1
Copy link
Copy Markdown
Contributor

rramkumar1 commented Jun 23, 2019

@spencerhance do you mind running a code coverage tool before & after just to verify there was no loss in coverage? It's not really a foolproof method to sanity check we are not losing coverage but I can't think of anything else.

@spencerhance spencerhance force-pushed the remove-lb-interface branch from 709a35a to 1092753 Compare June 24, 2019 19:29
@spencerhance
Copy link
Copy Markdown
Contributor Author

spencerhance commented Jun 24, 2019

@rramkumar1 go test -cover reports pkg/loadbalancers went from 75.9% to 74.1%

@rramkumar1
Copy link
Copy Markdown
Contributor

rramkumar1 commented Jun 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, rramkumar1, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0269fea into kubernetes:master Jun 24, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2019
@bowei
Copy link
Copy Markdown
Member

bowei commented Jun 24, 2019

need to revert until the vendor stuff is fixed

@rramkumar1 rramkumar1 mentioned this pull request Jun 24, 2019
Merged
@spencerhance spencerhance mentioned this pull request Jun 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei bowei left review comments

@freehan freehan Awaiting requested review from freehan

Assignees

@rramkumar1 rramkumar1

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spencerhance @k8s-ci-robot @rramkumar1 @bowei