Update OffscreenCanvas documentation, as it is widely available now#11823
Merged
LeeLenaleee merged 1 commit intochartjs:masterfrom Jun 30, 2024
Merged
Update OffscreenCanvas documentation, as it is widely available now#11823LeeLenaleee merged 1 commit intochartjs:masterfrom
LeeLenaleee merged 1 commit intochartjs:masterfrom
Conversation
etimberg
approved these changes
Jun 29, 2024
LeeLenaleee
approved these changes
Jun 30, 2024
|
gayalea risley
…On Sat, Jun 29, 2024, 8:51 AM Evert Timberg ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#11823 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEOYJ6JLMOR2PRH6YTPX7YDZJ3JYJAVCNFSM6AAAAABKDI4HGKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBZGY4DMNRWGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As documented by MDN,
OffscreenCanvasis widely available as of 2023, so this pull request updates the documentation accordingly.I tested rendering with
OffScreenCanvason my own app, and it works with Chrome and Firefox.However, in Safari 17.5 and 18.0-preview on macOS, it doesn't render anything for me when I switch from
canvastocanvas.transferControlToOffscreen(). There's unfortunately no error message in the console. I wasn't able to reproduce my problem with a simple test case -- the CodePen works fine in Safari -- so don't really have a good bug report to submit. I think it's also quite possible that there's something else going on in my code that Safari is tripping over.So perhaps for the moment, it might be worth merging this documentation patch. If people run into issues with Safari (or I can reproduce my issue with a smaller example) down the line, we can always open a new issue for it then.