Conversation
|
FYI @matekelemen |
This reverts commit c26fa90.
to avoid name conflict in Win
| @@ -24,5 +24,5 @@ std::string CodeLocation::GetCleanFileName() const | |||
| return fs::canonical(fs::path(GetFileName())).lexically_relative(fs::absolute(".")).string(); | |||
There was a problem hiding this comment.
@philbucher This isn't changed! Are you sure that you fixed the problem?
There was a problem hiding this comment.
Yes, the problem was in the implementation of fs::canonical in the C++11-compatible version of filesystem that we use
I found a couple of (in the meantime fixed) problems, thus after I updated the lib the problem should be solved.
Ideally you could test it :)
See what I wrote here
|
@philbucher I don't see the change in the code location Meanwhile, Why did you changed the |
Conflict in Win, see what I wrote here |
|
@philbucher I have checked your branch and it still suffers from the same error: RuntimeError: canonical: The system cannot find the path specified.: "..\..\applications\CoSimulationApplication\custom_external_libraries\CoSimIO\co_sim_io\sources\communication\communication.cpp"Would you please change it to the implementation of the Kratos Code location? |
|
|
I pushed the fix, @pooyan-dadvand can you please test it to make sure it works? And can you please post the output of the error message, I would like to see how it looks |
|
I have tested it and it works now on my machine! |
|
great, thanks for testing! Can someone approve then? |
Minor updates, mainly updating ext libs (mostly ASIO which is why this PR has so many changes)
Also directly using std::filesystem now