Skip to content

chore: Pre-commit hook for multi-character lstrip/rstrip#3756

Merged
maxrjones merged 2 commits intozarr-developers:mainfrom
maxrjones:ban-lstrip-rstrip
Mar 10, 2026
Merged

chore: Pre-commit hook for multi-character lstrip/rstrip#3756
maxrjones merged 2 commits intozarr-developers:mainfrom
maxrjones:ban-lstrip-rstrip

Conversation

@maxrjones
Copy link
Member

Adds a pre-commit hook to avoid bugs related to lstrip/rstrip mis-use, suggested by #3753 (comment).

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@maxrjones maxrjones requested a review from dcherian March 9, 2026 21:53
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

@maxrjones maxrjones merged commit 8d01860 into zarr-developers:main Mar 10, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants