🐛 Fix obstore listdir method using _relativize_path#3657
Merged
d-v-b merged 6 commits intozarr-developers:mainfrom Feb 13, 2026
Merged
🐛 Fix obstore listdir method using _relativize_path#3657d-v-b merged 6 commits intozarr-developers:mainfrom
d-v-b merged 6 commits intozarr-developers:mainfrom
Conversation
github-actions
bot
added
the
needs release notes
Merging this PR will not alter performance
Comparing 
Footnotes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3657 +/- ##
==========================================
- Coverage 60.88% 60.86% -0.03%
==========================================
Files 86 86
Lines 10182 10184 +2
==========================================
- Hits 6199 6198 -1
- Misses 3983 3986 +3
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
needs release notes
antoinegaston
force-pushed
the
fix-obstore-listdir
branch
from
ef19e83 to
99990a8
Compare
antoinegaston
force-pushed
the
fix-obstore-listdir
branch
from
06beed5 to
b93e8b6
Compare
Contributor
|
@antoinegaston I changed the release note to be a bugfix instead of misc, I hope that's OK! Otherwise, I think this is ready to go in. |
d-v-b
approved these changes
Feb 11, 2026
This was referenced Mar 9, 2026
Closed
TomNicholas
added a commit
to TomNicholas/VirtualiZarr
that referenced
this pull request
Mar 9, 2026
ZarrParser.__call__ was discarding the store-relative path from registry.resolve(), causing two bugs with nested stores: 1. open_group_async couldn't find the zarr group within the store 2. Chunk manifest paths were doubled (e.g. subdir/data.zarr/subdir/data.zarr/temp/0.0) Now correctly uses the store-relative path for group opening and the store root URI for chunk path construction. Note: also requires zarr-developers/zarr-python#3657 (on zarr main, not yet released) which fixes ObjectStore.list_dir corrupting directory names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
TomNicholas
added a commit
to TomNicholas/VirtualiZarr
that referenced
this pull request
Mar 10, 2026
ZarrParser.__call__ was discarding the store-relative path from registry.resolve(), causing two bugs with nested stores: 1. open_group_async couldn't find the zarr group within the store 2. Chunk manifest paths were doubled (e.g. subdir/data.zarr/subdir/data.zarr/temp/0.0) Now correctly uses the store-relative path for group opening and the store root URI for chunk path construction. Note: also requires zarr-developers/zarr-python#3657 (on zarr main, not yet released) which fixes ObjectStore.list_dir corrupting directory names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
TomNicholas
added a commit
to zarr-developers/VirtualiZarr
that referenced
this pull request
Mar 10, 2026
* add empty release notes * Fix ZarrParser when zarr store is nested inside object store root ZarrParser.__call__ was discarding the store-relative path from registry.resolve(), causing two bugs with nested stores: 1. open_group_async couldn't find the zarr group within the store 2. Chunk manifest paths were doubled (e.g. subdir/data.zarr/subdir/data.zarr/temp/0.0) Now correctly uses the store-relative path for group opening and the store root URI for chunk path construction. Note: also requires zarr-developers/zarr-python#3657 (on zarr main, not yet released) which fixes ObjectStore.list_dir corrupting directory names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add release note for nested store path fix (#913) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
maxrjones
pushed a commit
to maxrjones/VirtualiZarr
that referenced
this pull request
Mar 10, 2026
* add empty release notes * Fix ZarrParser when zarr store is nested inside object store root ZarrParser.__call__ was discarding the store-relative path from registry.resolve(), causing two bugs with nested stores: 1. open_group_async couldn't find the zarr group within the store 2. Chunk manifest paths were doubled (e.g. subdir/data.zarr/subdir/data.zarr/temp/0.0) Now correctly uses the store-relative path for group opening and the store root URI for chunk path construction. Note: also requires zarr-developers/zarr-python#3657 (on zarr main, not yet released) which fixes ObjectStore.list_dir corrupting directory names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add release note for nested store path fix (zarr-developers#913) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue relativizing paths for ObjectStore.
TODO:
docs/user-guide/*.mdchanges/