fix(router): fix gRPC nested fields mapping inside inline fragments#2584
fix(router): fix gRPC nested fields mapping inside inline fragments#2584
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBumps Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
===========================================
+ Coverage 38.19% 61.35% +23.15%
===========================================
Files 778 244 -534
Lines 116297 25757 -90540
Branches 8176 0 -8176
===========================================
- Hits 44417 15802 -28615
+ Misses 71518 8571 -62947
- Partials 362 1384 +1022 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.trivyignore.yaml:
- Around line 8-9: Update the wording in .trivyignore.yaml where you mention
reevaluation should occur at Go 1.26: change it to trigger reevaluation at Go
1.25.6 (since upstream go-containerregistry/main and docker/cli v29.2.1 require
1.25.6), and clarify that the CVE-2025-15558 is Windows-only and the router runs
on Linux, so the ignore is acceptable until Go 1.25.6 is adopted.
Fix has been merged to main already, no need to ignore it.
|
fyi the failing test is not because of this change. It is removed here https://github.com/wundergraph/cosmo/pull/2597/changes. Will merge this one as everything else is successful. |
Summary by CodeRabbit
Chores
Tests
Checklist