Parse command substitution in arithmetic expressions#2
Open
jdiamond wants to merge 1 commit intowebpro-nl:mainfrom
Open
Parse command substitution in arithmetic expressions#2jdiamond wants to merge 1 commit intowebpro-nl:mainfrom
jdiamond wants to merge 1 commit intowebpro-nl:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR addresses #1.
$(cmd)inside arithmetic contexts ($((expr)),((expr)),for ((…))) was being flattened into an opaqueArithmeticWord.valuestring. This addsArithmeticCommandExpansionto theArithmeticExpressionunion, with the sameinner/scriptfields used byCommandExpansionPartat the word level.A few design notes:
$(cmd)nodes found inside$((expr))word parts happens inparts.tsto avoid a circular import (parser→lexer).ArithmeticForpath callsresolveArithmeticExpansionsafteroffsetArithso positions are correct before scripts are parsed.e.textfor roundtrip safety.Tests cover raw parsing, resolution at all entry points, and roundtrip verification.
Note: adding a member to the
ArithmeticExpressionunion is a breaking change for TypeScript consumers with exhaustive switches — they'll get a compile error until they handle the new case.Happy to adjust anything!