Rename adapter and serializer methods to match the new store methods#3306
Rename adapter and serializer methods to match the new store methods#3306bmac merged 1 commit intowarp-drive-data:masterfrom
Conversation
|
Ping @amk221. I told you I didn't think this change was happening, I was wrong. |
|
:) thanks for the heads up. I predicted the future |
bmac
force-pushed
the
rename-adapter-serializer
branch
2 times, most recently
from
333da7d to
3e8c9ab
Compare
bmac
force-pushed
the
rename-adapter-serializer
branch
from
3e8c9ab to
77cef5c
Compare
There was a problem hiding this comment.
return this.extractFindQuery(store, typeClass, payload, id, 'findQuery');
bmac
force-pushed
the
rename-adapter-serializer
branch
from
77cef5c to
3306ed5
Compare
There was a problem hiding this comment.
This breaks backwards compatibility as well right? We should keep the old hooks in for 1.13 no?
There was a problem hiding this comment.
urlForFindRecord calls urlForFind if it looks like it has been overwritten https://github.com/emberjs/data/pull/3306/files#diff-fffd24b16fb23892703ed3ab601e6c80R123
|
I couldn't find any new tests for the deprecated behavior, are they there or do we still need to add them? |
|
This fails on travis when optional features are turned on |
bmac
force-pushed
the
rename-adapter-serializer
branch
6 times, most recently
from
e7cbfc7 to
4a63fbd
Compare
Adapter#find -> Adapter#findRecord and Adapter#findQuery -> Adapter#query BuildURLMixin#urlForFind -> BuildURLMixin#urlForFindRecord and BuildURLMixin#urlForFindQuery -> BuildURLMixin#urlForQuery Serializer#extractFind -> Serializer#extractFindRecord and Serializer#findQuery -> Serializer#extractQuery
bmac
force-pushed
the
rename-adapter-serializer
branch
from
4a63fbd to
fd3d5dd
Compare
Rename adapter and serializer methods to match the new store methods
3 participants
Adapter#find->Adapter#findRecordandAdapter#findQuery->Adapter#queryBuildURLMixin#urlForFind->BuildURLMixin#urlForFindRecordandBuildURLMixin#urlForFindQuery->BuildURLMixin#urlForQuerySerializer#extractFind->Serializer#extractFindRecordandSerializer#findQuery->Serializer#extractQuery