Skip to content

fix: type regression in vi.mocked() static class methods#9857

Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom
purepear:fix/type-regression-mocked-static-class-methods
Mar 17, 2026
Merged

fix: type regression in vi.mocked() static class methods#9857
sheremet-va merged 2 commits intovitest-dev:mainfrom
purepear:fix/type-regression-mocked-static-class-methods

Conversation

@purepear
Copy link
Contributor

@purepear purepear commented Mar 12, 2026

Description

Fixes typeing regression in vitest@4+'s vi.mocked()

  • Fixes vi.mocked(...) typing for static class methods by preserving mocked method members on shallow mocked constructors.
  • Adds a regression test covering mockImplementation() on a static class method to prevent future type regressions.

Resolves #9172

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link
Collaborator

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@sheremet-va sheremet-va merged commit 9092664 into vitest-dev:main Mar 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v4: vi.mocked() regression for static class methods types

3 participants