Skip to content

Merge 9508 9506#9510

Closed
hi-ogawa wants to merge 12 commits intovitest-dev:mainfrom
hi-ogawa:merge-9508-9506
Closed

Merge 9508 9506#9510
hi-ogawa wants to merge 12 commits intovitest-dev:mainfrom
hi-ogawa:merge-9508-9506

Conversation

@hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Jan 23, 2026

Description

Testing to see if merging #9508 and #9506 fixes astro #9324.

Okay, verified this fixes the reproduction from #9324.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa and others added 12 commits January 23, 2026 09:27
Fix up default ssr runnable environment so that third-party plugins
can use `server.environments.ssr.runner.import()` in post configureServer.

Closes vitest-dev#9324

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove `order: 'post'` from configureServer hooks so that Vitest's
SSR runner patch is available to other plugins' configureServer hooks.

Add test to verify ssr runner.import() works with correct external
semantics in configureServer.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ezes config

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 23, 2026

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@9510

@vitest/browser-playwright

npm i https://pkg.pr.new/@vitest/browser-playwright@9510

@vitest/browser-preview

npm i https://pkg.pr.new/@vitest/browser-preview@9510

@vitest/browser-webdriverio

npm i https://pkg.pr.new/@vitest/browser-webdriverio@9510

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@9510

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@9510

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@9510

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@9510

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@9510

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@9510

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@9510

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@9510

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@9510

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@9510

vitest

npm i https://pkg.pr.new/vitest@9510

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@9510

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@9510

commit: e17a64f

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e17a64f
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69731e75a5614000081706dc
😎 Deploy Preview https://deploy-preview-9510--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa
Copy link
Collaborator Author

hi-ogawa commented Jan 25, 2026

Closing as two PRs have been merged

@hi-ogawa hi-ogawa closed this Jan 25, 2026
@hi-ogawa hi-ogawa deleted the merge-9508-9506 branch January 25, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forced noExternal causes Vitest to fail with Astro components

1 participant