fix(core): Fix objectContaining expect utility to have more compatibility to jest's one#8241
Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom Jul 3, 2025
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
objectContaining expect utility to have more compatibility to jest's oneobjectContaining expect utility to have more compatibility to jest's one
…bility to jest's one
899acca to
c9ceb39
Compare
Contributor
Author
|
hmm...some tests which seems not to be related to |
sheremet-va
approved these changes
Jul 3, 2025
This was referenced Nov 3, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #8170
As the above issue mentions,
objectContainingcannot check equality of object which has symbol key correctly.This is because the current implementation of
objectContainingis based on simple iterator andObject.hasOwnProperty, and symbolic keys are not enumerated in simple iterator.In jest's implementation(ref: https://github.com/jestjs/jest/blob/7250950f1385cff688bfef514ea50eb2ffa6495d/packages/expect-utils/src/utils.ts#L46-L57), this is considered so jest's
objectContainingworks fine with object which has symbol key.This PR fixes #8170 and accomplish more compatibility of
objectContainingexpect utility to jest's one by addingObject.getOwnPropertySymbolsandObject.hasOwnbased property checking for symbol key considerationPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.