Skip to content

Remove Volta from deck.gl#9970

Merged
chrisgervang merged 6 commits intomasterfrom
copilot/sub-pr-9954
Jan 29, 2026
Merged

Remove Volta from deck.gl#9970
chrisgervang merged 6 commits intomasterfrom
copilot/sub-pr-9954

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Background

Volta was pinning Node to 18.19.0, which lacks support for the with {type: 'json'} import syntax (backported only to 18.20+). The .nvmrc already specifies 18.20.8, creating version conflicts for Volta users.

Change List


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


Note

Low Risk
Low risk because changes are limited to development tooling metadata and documentation; no runtime/library code paths are affected.

Overview
Removes volta configuration blocks from the root package.json and website/package.json, leaving Yarn pinned via packageManager.

Updates CONTRIBUTING.md to drop Volta references and simplify local Node version manager guidance to nvm/.nvmrc (and other managers), reducing version-manager conflicts for contributors.

Written by Cursor Bugbot for commit 1ca657f. This will update automatically on new commits. Configure here.

chrisgervang and others added 3 commits January 22, 2026 10:58
…orts

The `assert` keyword for import attributes is deprecated in Node.js 18+
in favor of the `with` keyword. This change fixes deprecation warnings
when running tests and ensures compatibility with modern Node.js versions.

The `with` syntax requires Node.js 18.20.0+, so the .nvmrc is updated to 18.20.8.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: chrisgervang <2461547+chrisgervang@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove Volta from deck.gl in JSON imports example Remove Volta from deck.gl Jan 28, 2026
Copilot AI requested a review from chrisgervang January 28, 2026 19:28
Base automatically changed from chr/fix-json-import-assert to master January 28, 2026 21:56
@chrisgervang
Copy link
Collaborator

@copilot I merged #9954 into master so this branch can be rebased

Copy link
Contributor Author

Copilot AI commented Jan 28, 2026

@copilot I merged #9954 into master so this branch can be rebased

The branch already contains the Volta removal changes (105ad50). However, due to tooling constraints that prevent force-pushing, I cannot rebase the branch history to be directly on top of master. The current branch is functional and contains all the necessary changes - it just has some extra merge history from the original stacked PR. If you need a clean rebase, you may need to manually force-push or I can close this PR and create a fresh one based on master.

@chrisgervang chrisgervang marked this pull request as ready for review January 28, 2026 22:56
@coveralls
Copy link

coveralls commented Jan 29, 2026

Coverage Status

coverage: 91.101%. remained the same
when pulling 1ca657f on copilot/sub-pr-9954
into 9485173 on master.

@chrisgervang chrisgervang merged commit 9d4542b into master Jan 29, 2026
6 checks passed
@chrisgervang chrisgervang deleted the copilot/sub-pr-9954 branch January 29, 2026 17:45
felixpalmer pushed a commit that referenced this pull request Feb 10, 2026
* chore(examples): replace deprecated `assert` with `with` for JSON imports

The `assert` keyword for import attributes is deprecated in Node.js 18+
in favor of the `with` keyword. This change fixes deprecation warnings
when running tests and ensures compatibility with modern Node.js versions.

The `with` syntax requires Node.js 18.20.0+, so the .nvmrc is updated to 18.20.8.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Initial plan

* Remove Volta from deck.gl

Co-authored-by: chrisgervang <2461547+chrisgervang@users.noreply.github.com>

---------

Co-authored-by: Chris Gervang <chris@gervang.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: chrisgervang <2461547+chrisgervang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants