Skip to content

feat(core): OrbitController supports maxBounds#10116

Merged
Pessimistress merged 2 commits intomasterfrom
x/orbit-max-bounds
Mar 20, 2026
Merged

feat(core): OrbitController supports maxBounds#10116
Pessimistress merged 2 commits intomasterfrom
x/orbit-max-bounds

Conversation

@Pessimistress
Copy link
Collaborator

Change List

  • make sure makeViewport is available before calling applyConstraints
  • OrbitController
  • tests

@coveralls
Copy link

coveralls commented Mar 18, 2026

Coverage Status

coverage: 91.021% (-0.04%) from 91.057%
when pulling c7f6485 on x/orbit-max-bounds
into 6f16d20 on master.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should document this, presumably, and add whats-new bullet
  • Should we have tests per controller or is the view-states spec sufficient? Test are so easy to generate these days.

@Pessimistress Pessimistress merged commit ec511f5 into master Mar 20, 2026
5 checks passed
@Pessimistress Pessimistress deleted the x/orbit-max-bounds branch March 20, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants