Fix module loading failure for redis module#3374
Open
roshkhatri wants to merge 6 commits intovalkey-io:unstablefrom
Open
Fix module loading failure for redis module#3374roshkhatri wants to merge 6 commits intovalkey-io:unstablefrom
roshkhatri wants to merge 6 commits intovalkey-io:unstablefrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3374 +/- ##
============================================
- Coverage 74.93% 74.67% -0.26%
============================================
Files 130 130
Lines 72769 72769
============================================
- Hits 54532 54343 -189
- Misses 18237 18426 +189 🚀 New features to boost your workflow:
|
Contributor
|
@roshkhatri How did you test it ? |
Member
Author
|
I tested this by loading a the minimal module that is mentioned on the issue #547 |
Contributor
|
@roshkhatri Shall we add it as a test then ? I believe this would be useful for folks to load a Redis compatible module to Valkey if other API(s) are available. |
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Probably added by mistake during some merge of valkey-io#1566 Signed-off-by: Ran Shidlansik <ranshid@amazon.com> Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
force-pushed
the
fix-crash-#547
branch
from
09c8807 to
1ab5be0
Compare
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #547
Fix module loading failure ([CRASH] If you have version.script file, make sure update Redis* to Valkey* #547) where modules using a GNU ld
version.scriptthat explicitly exportRedisModule_OnLoadfailed to load because the header remapped that symbol toValkeyModule_OnLoad.Remove the
#define RedisModule_OnLoad ValkeyModule_OnLoadmacro fromsrc/redismodule.hand add a comment explaining why theRedisModule_OnLoadentry-point must remain unmapped, while keeping server compatibility sincevalkey-serverprobes bothValkeyModule_OnLoadandRedisModule_OnLoad.Test by loading this minimal module hellovalkey.zip and the steps mentioned in the issue [CRASH] If you have version.script file, make sure update Redis* to Valkey* #547