Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for compacting the Android system property area via resetprop --compact, wiring a new CLI switch to a new low-level system_properties entry point.
Changes:
- Bumps the
system_propertiesexternal subproject to a revision that exposes a compaction API. - Adds an FFI binding and
SysProp::compact()wrapper for__system_property_compact. - Introduces
-c/--compactinresetpropCLI and routes execution through the new compaction path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| native/src/external/system_properties | Updates the system_properties subproject revision to pick up the underlying compaction support. |
| native/src/core/resetprop/mod.rs | Adds FFI + wrapper method for calling the property-area compaction routine. |
| native/src/core/resetprop/cli.rs | Adds --compact flag and execution path to trigger compaction from the CLI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Collaborator
Author
|
Test pass on a16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows compacting property area to remove holes after deleting prop. Usage:
resetprop --compactresetprop -cresetprop -c u:object_r:ab_update_gki_prop:s0