Remove empty CMD on tc_new_container_request()#25
Merged
oleg-nenashev merged 1 commit intotestcontainers:mainfrom Jul 10, 2024
Merged
Conversation
oleg-nenashev
changed the title
tc_new_container_request()
oleg-nenashev
approved these changes
Jul 10, 2024
oleg-nenashev
changed the title
tc_new_container_request()tc_new_container_request()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for starting up a rabbitmq container using the generic containers implementation.
What does this PR do?
Passing an empty string in the Cmd member of the ContainerRequest variable was causing a rabbitmq container to not launch properly. This change removes the empty string being passed to fix the issue.
Why is it important?
Passing a Cmd to ContainerRequest is not needed for the current implementation, and removing this does not affect the WireMock demo either. So, the fix works all around.
Related issues
Closes #24
How to test this PR
Compile and run the code from the issue (#24) and prove that the RabbitMQ container launches and does not stop immediately with the described error.