Normative: Disallow '_' for calendar , referring to UTS35#647
Merged
Normative: Disallow '_' for calendar , referring to UTS35#647
Conversation
Contributor
Author
|
This is response for our discussion in TG2 2022-01-03 and agree the "_" should cause a throw of error and we should make it clear in the spec. |
Contributor
Author
|
address tc39/test262#3173 |
gibson042
approved these changes
Jan 13, 2022
Contributor
Author
|
fix #646 |
ryzokuken
approved these changes
Jan 24, 2022
Member
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
Presenting this to plenary today.
Member
|
2022-01-24: Approved by TC39-TG1. |
Member
|
@FrankYFTang has this been approved by TG2 in the past? If so, I could merge this right away. |
Contributor
|
Also good for including in ES 2022. |
Make it clear "_" is not acceptable for calendar code
leobalter
force-pushed
the
FrankYFTang-patch-2
branch
from
35b075a to
0785d91
Compare
leobalter
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it clear "_" is not acceptable for calendar code