Conversation
ryzokuken
approved these changes
Apr 26, 2021
Member
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
Looks great to me, just one tiny comment.
Comment on lines
+10
to
+12
| If this is a bug with a specific implementation of ECMA-402, such as | ||
| a JavaScript engine or a browser, you might need to report it on their bug | ||
| tracker as well. |
Member
There was a problem hiding this comment.
Awesome recommendation! Should we also link the different engines' issue trackers? Doesn't seem to be a lot of effort on our end, but it might save the reporting a little time...
Member
|
Ping @leobalter |
Member
|
This is a net positive and we probably shouldn't keep it sitting too long on nits. I'll merge it in and then we can do anything extra in follow-on PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to open this for discussion.
This ECMA-402 repo has a different aspect compared to 262 as we accept issues with feature suggestions in our issues tracker. I'm adapting the current templates from 262 here and we should eventually add templates for new proposals, ideas, etc.
The PR template has a downstream notice to avoid issues on the spec chaining, I should add ECMA-262 in that list.
I'd like to get an idea of how this group sees the proposed additions. We can merge it if useful.