[minor]: raise toolchain requirement to 6.0, format code#34
[minor]: raise toolchain requirement to 6.0, format code#34tayloraswift merged 2 commits intomasterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the swift-jpeg library by raising the minimum toolchain requirement, formatting the code for better readability, and updating the project's build configuration. These changes ensure compatibility with the latest Swift features and improve the overall maintainability of the project. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request primarily updates the Swift toolchain requirement to 6.0 and applies consistent code formatting across the project. The changes are mostly stylistic and align with modern Swift practices, improving readability. I've identified one area in Package.swift where the code for applying Swift settings to targets could be made more concise and idiomatic. The rest of the changes, including updates to .gitignore and test scripts, look good.
| for target: Target in package.targets { | ||
| { | ||
| var settings: [SwiftSetting] = $0 ?? [] | ||
|
|
||
| settings.append(.enableUpcomingFeature("ExistentialAny")) | ||
| settings.append(.enableExperimentalFeature("StrictConcurrency")) | ||
|
|
||
| $0 = settings | ||
| } (&target.swiftSettings) | ||
| } |
There was a problem hiding this comment.
This loop for adding Swift settings to each target can be written more concisely and readably by using the + operator to append the new settings.
for target in package.targets {
target.swiftSettings = (target.swiftSettings ?? []) + [
.enableUpcomingFeature("ExistentialAny"),
.enableExperimentalFeature("StrictConcurrency"),
]
}
No description provided.