Skip to content

[minor]: raise toolchain requirement to 6.0, format code#34

Merged
tayloraswift merged 2 commits intomasterfrom
format-code
Mar 23, 2026
Merged

[minor]: raise toolchain requirement to 6.0, format code#34
tayloraswift merged 2 commits intomasterfrom
format-code

Conversation

@tayloraswift
Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the swift-jpeg library by raising the minimum toolchain requirement, formatting the code for better readability, and updating the project's build configuration. These changes ensure compatibility with the latest Swift features and improve the overall maintainability of the project.

Highlights

  • Toolchain Requirement: The minimum Swift toolchain requirement has been raised to 6.0, ensuring compatibility with the latest language features and improvements.
  • Code Formatting: The codebase has been formatted for improved readability and consistency.
  • Gitignore Updates: The .gitignore file was updated to exclude vscode build files and the Package.resolved file.
  • Package Manifest Changes: The Package.swift file was modified to include a dependency on dollup and enable upcoming and experimental features.
  • Test Script Improvements: The TestAll script was updated to include stricter error handling and dollup execution.
  • Code Modernization: Snippets were updated to use more modern Swift syntax.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/Tests.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily updates the Swift toolchain requirement to 6.0 and applies consistent code formatting across the project. The changes are mostly stylistic and align with modern Swift practices, improving readability. I've identified one area in Package.swift where the code for applying Swift settings to targets could be made more concise and idiomatic. The rest of the changes, including updates to .gitignore and test scripts, look good.

Comment on lines +64 to +73
for target: Target in package.targets {
{
var settings: [SwiftSetting] = $0 ?? []

settings.append(.enableUpcomingFeature("ExistentialAny"))
settings.append(.enableExperimentalFeature("StrictConcurrency"))

$0 = settings
} (&target.swiftSettings)
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This loop for adding Swift settings to each target can be written more concisely and readably by using the + operator to append the new settings.

for target in package.targets {
    target.swiftSettings = (target.swiftSettings ?? []) + [
        .enableUpcomingFeature("ExistentialAny"),
        .enableExperimentalFeature("StrictConcurrency"),
    ]
}

@tayloraswift tayloraswift merged commit c7aa484 into master Mar 23, 2026
14 checks passed
@tayloraswift tayloraswift deleted the format-code branch March 23, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant