Skip to content

fix: drop mustache dependency#923

Merged
ferhatelmas merged 1 commit intomasterfrom
ferhat/mustache
Mar 20, 2026
Merged

fix: drop mustache dependency#923
ferhatelmas merged 1 commit intomasterfrom
ferhat/mustache

Conversation

@ferhatelmas
Copy link
Member

What kind of change does this PR introduce?

Refactor

What is the current behavior?

Mustache is used for RLS tests but we don't use any partials, blocks, etc. Instead simple interpolation.

What is the new behavior?

Use string replace with one liner to drop the dependency.

Additional context

The less dependency we need, the better it is for maintenance even if dev dependency.

Copilot AI review requested due to automatic review settings March 20, 2026 10:05
@ferhatelmas ferhatelmas requested a review from a team as a code owner March 20, 2026 10:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the mustache dependency from the RLS test suite by replacing Mustache rendering with a small, purpose-built string interpolation helper.

Changes:

  • Replaced Mustache.render(...) usage in src/test/rls.test.ts with a local renderRlsTemplate(...) implementation.
  • Removed mustache and @types/mustache from package.json and pruned them from package-lock.json.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/test/rls.test.ts Introduces a lightweight {{var}} interpolator for test YAML templating and replaces Mustache usage.
package.json Drops mustache and @types/mustache dev dependencies.
package-lock.json Removes resolved entries for mustache and @types/mustache.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@TylerHillery TylerHillery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to have no dependencies left by this rate you're removing them

@ferhatelmas ferhatelmas merged commit f9be2f6 into master Mar 20, 2026
7 checks passed
@ferhatelmas ferhatelmas deleted the ferhat/mustache branch March 20, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants