Conversation
2 tasks
a5b7fe6 to
96b7825
Compare
za-arthur
approved these changes
Jan 24, 2025
za-arthur
left a comment
There was a problem hiding this comment.
Thank you for the PR. In overall all looks good to me. I just left couple of comments below.
96b7825 to
831465a
Compare
Pull Request Test Coverage Report for Build 13284154280Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
cd1f59e to
f7be9ad
Compare
f7be9ad to
19df503
Compare
⛔ Snyk checks have failed. 1 issues have been found so far.
⛔ code/snyk check is complete. 1 issues have been found. (View Details) |
ca62e66 to
1d2d112
Compare
| cursor, | ||
| }) | ||
|
|
||
| return response.status(200).send(results) |
There was a problem hiding this comment.
Cross-site Scripting (XSS)
Unsanitized input from an HTTP parameter flows into send, where it is used to render an HTML page returned to the user. This may result in a Cross-Site Scripting attack (XSS).
Line 69 | CWE-79 | Priority score 789 | Learn more about this vulnerability
2cf3930 to
aa14606
Compare
aa14606 to
1aed1fb
Compare
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Super slow search functionality when there are millions of objects
What is the new behavior?
Fast, reliable and performant search functionality across hundreds of millions of objects