fix(sms): support literal \n in SMS OTP templates#2438
Closed
ambujvashistha wants to merge 1 commit intosupabase:masterfrom
Closed
fix(sms): support literal \n in SMS OTP templates#2438ambujvashistha wants to merge 1 commit intosupabase:masterfrom
ambujvashistha wants to merge 1 commit intosupabase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes supabase/supabase#6435
Summary
Users want to use newlines (
\n) in their SMS OTP templates configured via environment variables, but SMS providers were sending the literal string\ninstead of an actual newline character.This PR fixes the issue by replacing any literal
\nsequences in the SMS template string with actual newline characters before parsing the Go template.Changes
internal/conf/configuration.go, addedstrings.ReplaceAll(template, "\\n", "\n")before parsing bothSms.TemplateandMFA.Phone.Template