Fixes to SYS_READ changes in PR #727 per review.#729
Merged
xor-gate merged 6 commits intostlink-org:masterfrom Jul 28, 2018
Merged
Fixes to SYS_READ changes in PR #727 per review.#729xor-gate merged 6 commits intostlink-org:masterfrom
xor-gate merged 6 commits intostlink-org:masterfrom
Conversation
calculation of *ret for EOF case.
of a file. fread (on stm32) get them (say 3 bytes), then askes for more. do_semihosting gets a read return of 0 and tries to write that. mem_write alters the address to be aligned and overwrites then 3 bytes from the last read. This change simply tells mem_write to do nothing if len is 0.
donmr
changed the title
Contributor
|
Thanks @Fabien-Chouteau and @donmr ! |
donmr
added a commit
to donmr/stlink
that referenced
this pull request
Jul 28, 2018
Fixes to SYS_READ changes in PR stlink-org#727 per review. (stlink-org#729)
donmr
added a commit
to donmr/stlink
that referenced
this pull request
Jul 28, 2018
Fixes to SYS_READ changes in PR stlink-org#727 per review. (stlink-org#729)
slyshykO
reviewed
Jul 29, 2018
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I agree with Fabien-Chouteau's review items. Thanks for catching my sloppy errors.
Here is a PR with those things fixed.