Fixed st-trace reconnect on Windows#1292
Merged
Nightwalker-87 merged 1 commit intostlink-org:developfrom Jan 8, 2023
Merged
Conversation
Nightwalker-87
requested changes
Jan 2, 2023
Member
Nightwalker-87
left a comment
Nightwalker-87
left a comment
There was a problem hiding this comment.
I'd suggest to fix this in gdb-server.c as well, as mentioned before, so we can include some testing there too. 😉
6 tasks
Collaborator
Author
|
I was wrong about gdb-server.c needing a fix. The signal handler directly cleans up resources before returning. |
Nightwalker-87
approved these changes
Jan 2, 2023
Member
|
Now awaiting testing by @jared52005. |
Nightwalker-87
added
needs/testing
status/resolved-verified
and removed
needs/testing
labels
Nightwalker-87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix issue #1272.
The windows signal handling was returning FALSE which caused the default handler to be called. The default handler called ExitProcess before our process had a chance to cleanup. While the code looks similar, st-util does not have the same issue since it actually cleans up its resources in the signal handler.