Skip to content

Fixed few warnings for msvc about type conversion with possible lost data#1179

Merged
Nightwalker-87 merged 2 commits intostlink-org:developfrom
slyshykO:fix-few-msvc-warn
Aug 15, 2021
Merged

Fixed few warnings for msvc about type conversion with possible lost data#1179
Nightwalker-87 merged 2 commits intostlink-org:developfrom
slyshykO:fix-few-msvc-warn

Conversation

@slyshykO
Copy link
Collaborator

No description provided.

@slyshykO slyshykO changed the title Fixes few warnings for msvc about type conversion with possible lost data. WIP: Fixes few warnings for msvc about type conversion with possible lost data. Aug 15, 2021
@slyshykO slyshykO marked this pull request as draft August 15, 2021 09:22
@slyshykO slyshykO marked this pull request as ready for review August 15, 2021 09:37
@slyshykO slyshykO changed the title WIP: Fixes few warnings for msvc about type conversion with possible lost data. Fixes few warnings for msvc about type conversion with possible lost data. Aug 15, 2021
@Nightwalker-87 Nightwalker-87 self-requested a review August 15, 2021 10:30
@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Aug 15, 2021

I like the attempt to use precise typedefs. However the best solution in the medium term would be to use them in the definition of core variables already... (Which shall not be part of this PR however.) It's a general design issue (see #909).

@Nightwalker-87 Nightwalker-87 added this to the v1.7.1 milestone Aug 15, 2021
@Nightwalker-87 Nightwalker-87 changed the title Fixes few warnings for msvc about type conversion with possible lost data. Fixed few warnings for msvc about type conversion with possible lost data Aug 15, 2021
@Nightwalker-87 Nightwalker-87 merged commit c758341 into stlink-org:develop Aug 15, 2021
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Aug 15, 2021
@slyshykO slyshykO deleted the fix-few-msvc-warn branch January 15, 2023 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants