Merged
Conversation
…) is called in a component, rather than on the alphabetization of link names.
feldergast
added
the
Major Feature
github-actions
bot
added
AT: WIP
|
CLANG-FORMAT TEST - PASSED |
feldergast
added
the
AT: WIP
gvoskuilen
approved these changes
Jan 26, 2026
Contributor
gvoskuilen
left a comment
gvoskuilen
left a comment
There was a problem hiding this comment.
Looks good. Couple typos in comments that can be fixed in a subsequent PR if needed.
| if ( clink->component[0] == ULONG_MAX ) { | ||
| output.output("WARNING: Found unused link: %s\n", clink->name.c_str()); | ||
| 2 - Dangling link. This happens when order == 0 and we are a nonlocal link, or when order == 0 and we are NOT | ||
| a nonlocal link |
Contributor
There was a problem hiding this comment.
Comment needs fixing. Dangling link when (order == 0, nonlocal) or (order == 1, ~nonlocal)
|
|
||
|
|
||
| /** | ||
| Gets the next value or the order field of the link. The ordering of events based on links will be based on |
Contributor
There was a problem hiding this comment.
Should this be "Gets the next value 'for' the order field"?
feldergast
removed
the
AT: WIP
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist
Build InformationTest Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements
Using Repos:
Pull Request Author: feldergast |
Contributor
|
FYI - checked that this branch is passing on TCL CI pipeline as well |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist
Build InformationTest Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements
|
Contributor
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ gvoskuilen ]! |
Contributor
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing how the event ordering based on the links they were sent on. Currently it is based on the alphabetized link name, this PR moves control of ordering to the model developer by basing it on the order in which configureLink() is called. This PR leaves ordering for self links the same (they are all given the same order tag, so events with the same deliver time and priority will deliver in the order they were sent).
This is the implementation for issue #1540
NOTE: Since this PR changes some of the outputs of test reference files, we will need to force push the reference file update on Elements and then send this PR for testing.