LogHistogram by ct-clmsn · Pull Request #1410 · sstsimulator/sst-core

ct-clmsn · 2025-08-20T20:32:54Z

initial import of LogBinHistogram for #359 which is related to #381

github-actions · 2025-08-20T20:33:18Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v20 to check formatting

github-actions · 2025-08-20T20:33:23Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2025-08-20T20:35:18Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v20 to check formatting

github-actions · 2025-08-20T20:35:22Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2025-08-20T20:35:40Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2025-08-20T20:35:44Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v20 to check formatting

github-actions · 2025-08-20T20:42:02Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v20 to check formatting

github-actions · 2025-08-20T20:42:08Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2025-08-20T20:43:13Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-08-21T14:42:36Z

CMAKE-FORMAT TEST - PASSED

ct-clmsn · 2025-08-21T14:52:56Z

@feldergast I'm not sure what the linting check is unhappy with - could use a second glance.

berquist · 2025-08-21T14:57:23Z

I had to approve your workflow to run, but you can see it here: https://github.com/sstsimulator/sst-core/actions/runs/17130304179/job/48593800032?pr=1410

ct-clmsn · 2025-08-21T15:38:17Z

@berquist those lines look equivalent ... it's kind of throwing me off, is this a spacing issue?

feldergast · 2025-08-21T15:52:59Z

If you have pre-commit set up on your system, you can just run "pre-commit run --all" and it should do the proper formatting as part of those checks. If not, getting that working may be easier than getting clang-format20 on your system.

berquist · 2025-08-21T16:10:09Z

It is hard to read from the diff, because most don't display it well, but if you do what Scott says, you'll see that it's trailing whitespace. You can also see that "trim trailing whitespace" failed before running clang-format.

github-actions · 2025-08-22T14:02:47Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-08-22T14:02:54Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-08-22T14:20:58Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

feldergast

Administrative review: Approved by @leekillough

sst-autotester · 2025-12-01T20:48:04Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester · 2025-12-01T20:51:08Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2373
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2327
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2326
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 971
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 877
Status: STARTED

Using Repos:

Repo: CORE (ct-clmsn/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: ct-clmsn

sst-autotester · 2025-12-01T21:06:35Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Result: FAILED
Build #: 2373
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements/2373/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Result: FAILED
Build #: 2327
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2/2327/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Result: FAILED
Build #: 2326
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2/2326/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Result: FAILED
Build #: 971
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist/971/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Result: FAILED
Build #: 877
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements/877/consoleFull
Job: - Status: FAILURE

feldergast · 2025-12-01T21:28:11Z

Looks like core has diverged too far. This PR fails with missing type declarations. Will need to be rebased, fix and repushed.

leekillough · 2025-12-02T07:02:57Z

I have created https://github.com/leekillough/sst-core/tree/loghistogram which is merged with devel and squashed with git reset --soft but I get compilation errors which indicate possibly unfinished work, or dependence on removed features like StatisticBase::StatMode_t and StatisticBase::STAT_MODE_COUNT:

In file included from ../../../../src/sst/core/statapi/statbase.cc:20:
../../../../src/sst/core/statapi/statlghistogram.h:308:30: error: ‘SST::Statistics::StatisticBase::StatMode_t’ has not been declared
  308 |     bool isStatModeSupported(StatisticBase::StatMode_t mode) const override
      |                              ^~~~~~~~~~~~~
../../../../src/sst/core/statapi/statlghistogram.h: In member function ‘bool SST::Statistics::LogBinHistogramStatistic<BinDataType>::isStatModeSupported(int) const’:
../../../../src/sst/core/statapi/statlghistogram.h:311:29: error: ‘STAT_MODE_COUNT’ is not a member of ‘SST::Statistics::StatisticBase’
  311 |         case StatisticBase::STAT_MODE_COUNT:
      |                             ^~~~~~~~~~~~~~~
../../../../src/sst/core/statapi/statlghistogram.h:312:29: error: ‘STAT_MODE_PERIODIC’ is not a member of ‘SST::Statistics::StatisticBase’
  312 |         case StatisticBase::STAT_MODE_PERIODIC:
      |                             ^~~~~~~~~~~~~~~~~~
../../../../src/sst/core/statapi/statlghistogram.h:313:29: error: ‘STAT_MODE_DUMP_AT_END’ is not a member of ‘SST::Statistics::StatisticBase’
  313 |         case StatisticBase::STAT_MODE_DUMP_AT_END:
      |                             ^~~~~~~~~~~~~~~~~~~~~
../../../../src/sst/core/statapi/statlghistogram.h: In instantiation of ‘class SST::Statistics::LogBinHistogramStatistic<int>’:
../../../../src/sst/core/statapi/statbase.cc:247:1:   required from here
../../../../src/sst/core/statapi/statlghistogram.h:308:10: error: ‘bool SST::Statistics::LogBinHistogramStatistic<BinDataType>::isStatModeSupported(int) const [with BinDataType = int]’ marked ‘override’, but does not override
  308 |     bool isStatModeSupported(StatisticBase::StatMode_t mode) const override
      |          ^~~~~~~~~~~~~~~~~~~

If this feature is still desired, someone else will need to spend some time bringing the code up-to-date.

gvoskuilen · 2025-12-04T20:35:54Z

src/sst/core/statapi/statlghistogram.h

+            return false;
+        }
+        return false;
+    }


The isStatModeSupported() function can be removed. The STAT_MODE_* types no longer exist and the default implementation of the function is correct for statlghistogram. Background: The function signature changed to take a bool indicating COUNT (false) or PERIODIC (true). DUMP_AT_END was always unused and no longer exists.

jleidel · 2025-12-10T13:50:22Z

@gvoskuilen any guidance here to port the code to the latest stats codebase?

ct.clmsn added 2 commits August 20, 2025 16:29

initial import

cd4b28f

initial import

d4877a6

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels Aug 20, 2025

github-actions bot added AT: CMAKE-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Aug 20, 2025

fix formatting issue

a7369bf

github-actions bot added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Aug 20, 2025

fix formatting issue

2fe782f

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Aug 20, 2025

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Aug 20, 2025

lint fixes

fb37627

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Aug 20, 2025

lint fixes

8b07fbd

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels Aug 20, 2025

github-actions bot added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Aug 20, 2025

removed trailing space

9508e90

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels Aug 22, 2025

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Aug 22, 2025

leekillough approved these changes Nov 29, 2025

View reviewed changes

feldergast approved these changes Dec 1, 2025

View reviewed changes

feldergast added the AT: PRE-TEST INSPECTED label Dec 1, 2025

sst-autotester removed the AT: PRE-TEST INSPECTED label Dec 1, 2025

feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Dec 1, 2025

This was referenced Dec 2, 2025

Histogram does not handle floating point data correctly #870

Open

Log Histogram #359

Open

gvoskuilen reviewed Dec 4, 2025

View reviewed changes

Conversation

ct-clmsn commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

ct-clmsn commented Aug 21, 2025

Uh oh!

berquist commented Aug 21, 2025

Uh oh!

ct-clmsn commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feldergast commented Aug 21, 2025

Uh oh!

berquist commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

sst-autotester commented Aug 22, 2025

Uh oh!

feldergast left a comment

Choose a reason for hiding this comment

Uh oh!

sst-autotester commented Dec 1, 2025

Uh oh!

sst-autotester commented Dec 1, 2025

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Using Repos:

Uh oh!

sst-autotester commented Dec 1, 2025

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Job: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Uh oh!

feldergast commented Dec 1, 2025

Uh oh!

leekillough commented Dec 2, 2025

Uh oh!

gvoskuilen Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

jleidel commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

ct-clmsn commented Aug 20, 2025 •

edited

Loading

ct-clmsn commented Aug 21, 2025 •

edited

Loading