Support Kotlin parameter default values in handler methods#1741
Closed
diesieben07 wants to merge 2 commits intospring-projects:masterfrom
Closed
Support Kotlin parameter default values in handler methods#1741diesieben07 wants to merge 2 commits intospring-projects:masterfrom
diesieben07 wants to merge 2 commits intospring-projects:masterfrom
Conversation
Allows using default parameter values for any method parameters resolved via AbstractNamedValueMethodArgumentResolver, similar to defaultValue parameter of e.g. @RequestParam annotation, but skipping the converter chain. Issues: SPR-16598
Contributor
Author
|
Rebased onto current master and resolved merge conflicts. |
|
An ETA when it can be merged? |
|
is something wrong with this pull request? |
Member
|
@raderio please be patient, we'll get to it as soon as we can. |
Contributor
|
Current Kotlin API forces us to have a rather involved implementation which is not a good fit with our infra. We would need a reflection API that allows Spring to know an optional parameter default value without calling the function. I will discuss with Kotlin team to see what is possible here in Kotlin 1.3. |
Contributor
Author
|
I am not sure if what you want is possible. This is impossible to represent in the way you propose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows using default parameter values for any method parameters resolved
via
AbstractNamedValueMethodArgumentResolver, similar todefaultValueparameter of e.g.
@RequestParamannotation, but skipping the converterchain.
Issues: SPR-16598.