Use new builder pattern for MistralAiChatOptions#5551
Merged
sdeleuze merged 1 commit intospring-projects:mainfrom Mar 6, 2026
Merged
Use new builder pattern for MistralAiChatOptions#5551sdeleuze merged 1 commit intospring-projects:mainfrom
MistralAiChatOptions#5551sdeleuze merged 1 commit intospring-projects:mainfrom
Conversation
ericbottard
approved these changes
Mar 6, 2026
Member
ericbottard
left a comment
ericbottard
left a comment
There was a problem hiding this comment.
LGTM with small polish. Feel free to merge yourself when done
...pring-ai-mistral-ai/src/main/java/org/springframework/ai/mistralai/MistralAiChatOptions.java
Show resolved
Hide resolved
...pring-ai-mistral-ai/src/main/java/org/springframework/ai/mistralai/MistralAiChatOptions.java
Show resolved
Hide resolved
...pring-ai-mistral-ai/src/main/java/org/springframework/ai/mistralai/MistralAiChatOptions.java
Show resolved
Hide resolved
Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
force-pushed
the
mistral-ai-new-builder
branch
from
a669a5e to
cea1ffd
Compare
tzolov
reviewed
Mar 9, 2026
| public MistralAiChatOptions() { | ||
| } | ||
|
|
||
| protected MistralAiChatOptions(String model, @Nullable Double temperature, @Nullable Double topP, |
Contributor
There was a problem hiding this comment.
I presume that those @nullable will allow creating a delta options at runtime with the builder?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.