Exclude repos by glob#70
Merged
brendan-kellam merged 5 commits intosourcebot-dev:mainfrom Nov 14, 2024
Merged
Conversation
brendan-kellam
requested changes
Nov 14, 2024
Contributor
brendan-kellam
left a comment
brendan-kellam
left a comment
There was a problem hiding this comment.
Thanks for the change!! Left a couple of nit comments. Could you also add a example of glob patterns being used to configs/filter.json.
…nt and updated description for exclude repos/projects in schema json, improved existing micromatch test and added test for name exact match
Contributor
Author
|
All good calls, addressed everything. |
brendan-kellam
approved these changes
Nov 14, 2024
Contributor
|
Merged. Thanks for the contribution @Steven-Nagie! |
Contributor
Author
Thank you! Sourcebot has been a big help, happy to contribute in my small way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #69