Skip to content

build: match the node types package and node version#531

Merged
zimeg merged 1 commit intomainfrom
zimeg-build-node-20-lock
Jan 12, 2026
Merged

build: match the node types package and node version#531
zimeg merged 1 commit intomainfrom
zimeg-build-node-20-lock

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jan 9, 2026

Summary

This PR replaces #529 to prefer @types/node@20 to match our current supported Node version:

https://github.com/slackapi/slack-github-action/blob/3493f18217f6e55d55ff3ea694dec41304e53e97/.nvmrc

Requirements

@zimeg zimeg self-assigned this Jan 9, 2026
@zimeg zimeg requested a review from a team as a code owner January 9, 2026 00:02
@zimeg zimeg added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code semver:patch tests labels Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (3493f18) to head (39e7db0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           7        7           
  Lines         722      722           
=======================================
  Hits          721      721           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg
Copy link
Member Author

zimeg commented Jan 12, 2026

@WilliamBergamin I appreciate the quick and kind review 🙏 ✨

@zimeg zimeg merged commit 5fa0df4 into main Jan 12, 2026
8 checks passed
@zimeg zimeg deleted the zimeg-build-node-20-lock branch January 12, 2026 20:38
@zimeg zimeg added this to the 2.2 milestone Jan 12, 2026
@zimeg zimeg modified the milestones: 2.2, 3.0 Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code semver:patch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants