Suppress Read() error on closing websocket-proxy connection#22
Open
Suppress Read() error on closing websocket-proxy connection#22
Conversation
When one end of the websocket proxy closes the connection (e.g. a browser reload) a net.OpError 'use of closed network connection' error will be triggered in the blocking Read()/ReadMessage() call of the other direction. This is a rather hacky attempt to detect this situation and not trigger a log.Warning(). Signed-off-by: Rudolph Bott <r@spam.wtf>
Collaborator
|
I might make sense to use https://github.com/nhooyr/websocket, which supports graceful connection closing |
geigi
force-pushed
the
main
branch
5 times, most recently
from
71eaf32 to
2d5a682
Compare
Collaborator
|
Golang now has an official websocket package: https://pkg.go.dev/golang.org/x/net/websocket#example-Handler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one end of the websocket<->socket proxy closes the connection (e.g. due to a browser page reload) a net.OpError 'use of closed network connection' error will be triggered in the blocking
Read()/ReadMessage()call of the other direction.This is a rather hacky attempt to detect this situation and not trigger a log.Warning().
TCPConn(as opposed toConnreturned bynet.Dial()) comes with aCloseRead()method which gracefully terminates all open reads while closing a connection. We could therefore replacenet.Dial()withnet.TCPDial(). However, that only helps in one direction, as the other one builds upon the websocket handler and there is no such thing asCloseRead()there.