Add support for making timestamp requests in JSON format by malancas · Pull Request #247 · sigstore/timestamp-authority

malancas · 2023-02-14T00:22:28Z

Summary

Closes #229.

Hayden-IO/timestamp#1 must be merged first.

This supports the ability to pass timestamp requests in JSON format to the TSA.

Release Note

Documentation

Signed-off-by: Meredith Lancaster <malancas@github.com>

pkg/api/timestamp.go

Signed-off-by: Meredith Lancaster <malancas@github.com>

Makefile

Signed-off-by: Meredith Lancaster <malancas@github.com>

codecov · 2023-02-16T15:36:49Z

Codecov Report

Merging #247 (81bde21) into main (53a3544) will increase coverage by 0.40%.
The diff coverage is 64.44%.

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   52.70%   53.11%   +0.40%     
==========================================
  Files          19       20       +1     
  Lines        1146     1188      +42     
==========================================
+ Hits          604      631      +27     
- Misses        484      496      +12     
- Partials       58       61       +3

Impacted Files	Coverage Δ
cmd/timestamp-cli/app/timestamp.go	`42.26% <0.00%> (-2.30%)`	⬇️
pkg/client/options.go	`89.74% <66.66%> (-10.26%)`	⬇️
pkg/tests/build_test_data.go	`76.00% <76.00%> (ø)`
pkg/client/timestamp_client.go	`85.00% <100.00%> (+0.78%)`	⬆️
pkg/verification/verify_request.go	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Meredith Lancaster <malancas@github.com>

pkg/tests/api_test.go

Signed-off-by: Meredith Lancaster <malancas@github.com>

README.md

cmd/timestamp-cli/app/timestamp.go

pkg/api/timestamp.go

pkg/tests/buildTestData.go

Signed-off-by: Meredith Lancaster <malancas@github.com>

Hayden-IO

just a few nits, lgtm

pkg/api/timestamp.go

Signed-off-by: Meredith Lancaster <malancas@github.com>

malancas added 9 commits February 8, 2023 16:38

fix help command

66ac24b

Signed-off-by: Meredith Lancaster <malancas@github.com>

start adding support for json requests

ab3e40d

Signed-off-by: Meredith Lancaster <malancas@github.com>

ignore sample json requests, responses

456d61e

Signed-off-by: Meredith Lancaster <malancas@github.com>

test timestamp dep changes

38b1af7

Signed-off-by: Meredith Lancaster <malancas@github.com>

Merge branch 'main' into add-req-json-support

a949653

start adding support for json requests and responses

28ccfd8

Signed-off-by: Meredith Lancaster <malancas@github.com>

use updated EncodingHandler method

e50c334

Signed-off-by: Meredith Lancaster <malancas@github.com>

add support for json, asn1 timestamp formatting in the CLI

4a511de

Signed-off-by: Meredith Lancaster <malancas@github.com>

remove json producer support

056659c

Signed-off-by: Meredith Lancaster <malancas@github.com>

github-advanced-security bot found potential problems Feb 15, 2023

View reviewed changes

pkg/api/timestamp.go Fixed Show fixed Hide fixed

malancas added 2 commits February 15, 2023 16:56

linting

cc54325

Signed-off-by: Meredith Lancaster <malancas@github.com>

only support json requests

7dce13c

Signed-off-by: Meredith Lancaster <malancas@github.com>

malancas commented Feb 16, 2023

View reviewed changes

Makefile Show resolved Hide resolved

malancas added 2 commits February 16, 2023 08:31

dont use breaking change from timestamp dep

5e6e57a

Signed-off-by: Meredith Lancaster <malancas@github.com>

cleanup

c1bac84

Signed-off-by: Meredith Lancaster <malancas@github.com>

malancas added 10 commits February 16, 2023 09:15

cleanup tests

830356b

Signed-off-by: Meredith Lancaster <malancas@github.com>

add const for timestamp query mediat type

8887566

Signed-off-by: Meredith Lancaster <malancas@github.com>

use timestamp query const

0cdd26b

Signed-off-by: Meredith Lancaster <malancas@github.com>

add more help comments

ce1b576

Signed-off-by: Meredith Lancaster <malancas@github.com>

add comment for client content type option

1799552

Signed-off-by: Meredith Lancaster <malancas@github.com>

add test cases for timestamp creation

bb94794

Signed-off-by: Meredith Lancaster <malancas@github.com>

working json helper functions

349b5ed

Signed-off-by: Meredith Lancaster <malancas@github.com>

cleanup json testing

f168295

Signed-off-by: Meredith Lancaster <malancas@github.com>

last testing updates

330d746

Signed-off-by: Meredith Lancaster <malancas@github.com>

add license

8d52013

Signed-off-by: Meredith Lancaster <malancas@github.com>

malancas mentioned this pull request Feb 16, 2023

Support JSON Requests Hayden-IO/timestamp#1

Merged

malancas added 3 commits March 8, 2023 16:43

dont add user input to error used for logging

a439655

Signed-off-by: Meredith Lancaster <malancas@github.com>

Merge branch 'main' into add-req-json-support

027ad3f

Merge branch 'main' into add-req-json-support

e0ed06d

malancas added 10 commits March 14, 2023 18:01

update timestamp dep

3ff3e33

Signed-off-by: Meredith Lancaster <malancas@github.com>

try to parse JSON reqeust to timestamp.Request

f8aa686

Signed-off-by: Meredith Lancaster <malancas@github.com>

finalize json request format

30ca30e

Signed-off-by: Meredith Lancaster <malancas@github.com>

fix policy oid parsing

2f8a482

Signed-off-by: Meredith Lancaster <malancas@github.com>

remove replace statement

b1515c1

Signed-off-by: Meredith Lancaster <malancas@github.com>

remove print statement

da7d97b

Signed-off-by: Meredith Lancaster <malancas@github.com>

update http status code

3e95238

Signed-off-by: Meredith Lancaster <malancas@github.com>

linting

0d38407

Signed-off-by: Meredith Lancaster <malancas@github.com>

add comments around parsing json requests

60c05cf

Signed-off-by: Meredith Lancaster <malancas@github.com>

update exts and oid test

c530dc8

Signed-off-by: Meredith Lancaster <malancas@github.com>

malancas commented Mar 31, 2023

View reviewed changes

pkg/tests/api_test.go Show resolved Hide resolved

malancas marked this pull request as ready for review March 31, 2023 15:37

malancas requested a review from a team as a code owner March 31, 2023 15:37

add example with JSON request

f23b0d5

Signed-off-by: Meredith Lancaster <malancas@github.com>

Hayden-IO reviewed Apr 10, 2023

View reviewed changes

malancas added 7 commits April 10, 2023 11:19

Merge branch 'main' into add-req-json-support

45f9e9d

pr feedback

2b9b79a

Signed-off-by: Meredith Lancaster <malancas@github.com>

rework der and json request parsing to verify hash alg earlier

9e89e1f

Signed-off-by: Meredith Lancaster <malancas@github.com>

linting issues

e8ef97d

Signed-off-by: Meredith Lancaster <malancas@github.com>

return weak hash error

f4399fe

Signed-off-by: Meredith Lancaster <malancas@github.com>

use weak hash error in verification test

5dec1ee

Signed-off-by: Meredith Lancaster <malancas@github.com>

test that expected weak hash algorithm error is returned

eb5383c

Signed-off-by: Meredith Lancaster <malancas@github.com>

Hayden-IO reviewed Apr 12, 2023

View reviewed changes

pkg/api/timestamp.go Outdated Show resolved Hide resolved

pkg/api/timestamp.go Show resolved Hide resolved

pkg/api/timestamp.go Outdated Show resolved Hide resolved

pr feedback

81bde21

Signed-off-by: Meredith Lancaster <malancas@github.com>

Hayden-IO approved these changes Apr 12, 2023

View reviewed changes

malancas merged commit ad80ccb into sigstore:main Apr 12, 2023

malancas deleted the add-req-json-support branch April 12, 2023 22:54

Hayden-IO mentioned this pull request Mar 26, 2024

trustroot: initial client config messages sigstore/protobuf-specs#277

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for making timestamp requests in JSON format#247

Add support for making timestamp requests in JSON format#247
malancas merged 45 commits intosigstore:mainfrom
malancas:add-req-json-support

malancas commented Feb 14, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 16, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hayden-IO left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

malancas commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Release Note

Documentation

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hayden-IO left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

malancas commented Feb 14, 2023 •

edited

Loading

codecov bot commented Feb 16, 2023 •

edited

Loading