Use tlsSettings instead of defaultTlsSettings#8
Merged
dmjio merged 1 commit intoscotty-web:masterfrom Sep 26, 2020
soupi:fix-for-warp-tls-3.3.0
Merged
Use tlsSettings instead of defaultTlsSettings#8dmjio merged 1 commit intoscotty-web:masterfrom soupi:fix-for-warp-tls-3.3.0
dmjio merged 1 commit intoscotty-web:masterfrom
soupi:fix-for-warp-tls-3.3.0
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warp-tls-3.3.0 made a breaking change removing
certFileandkeyFile(changelog).This commit uses the
tlsSettingssmart constructor instead, which is available since warp-tls-3.1.0 (which came out 5 years ago).Note that I did not get the chance to test this yet, just made sure it compiled against warp-tls-3.3.0.