Fix vcfconvert ALT parsing, null deref, and sample compression#2528
Open
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Open
Fix vcfconvert ALT parsing, null deref, and sample compression#2528sirus20x6 wants to merge 1 commit intosamtools:developfrom
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Conversation
1. _set_chrom_pos_ref_alt (~line 207): The while/if conditions checked isspace_c(*tsv->se) (the constant end pointer) instead of !isspace_c(*se) (the advancing scan pointer), causing the ALT allele scan to terminate immediately or never advance. 2. bgzf_thread_pool calls (~lines 1084, 1234): Added NULL check for hout before calling bgzf_thread_pool, preventing a crash when hap output is suppressed by passing '.' as the filename. 3. sample_compressed assignment (~lines 923, 1048, 1197): Changed `sample_compressed = 0` to `sample_compressed = 1` so that .gz sample filenames actually enable compressed output.
sirus20x6
force-pushed
the
fix/vcfconvert-parsing
branch
from
b573161 to
b23579b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_set_chrom_pos_ref_alt— while loop checked*tsv->se(constant end pointer) instead of*se(scan pointer), making it a no-opbgzf_thread_pool(hout, ...)when hap output is suppressed with.sample_compressed = 0to= 1in three places — .gz sample filenames were never actually compressedTest plan
.gzsample output files are compressed