Conversation
tovbinm
reviewed
Aug 27, 2018
| @RunWith(classOf[JUnitRunner]) | ||
| class OpStringIndexerTest extends FlatSpec with TestSparkContext{ | ||
|
|
||
| Spec[OpStringIndexer[_]] should "correctly set the wrapped spark stage params" in { |
Collaborator
There was a problem hiding this comment.
please move OpStringIndexer test portion from OpStringIndexerNoFilterTest to here as well
tovbinm
reviewed
Aug 27, 2018
| def indexed( | ||
| unseenName: String = OpStringIndexerNoFilter.UnseenNameDefault, | ||
| handleInvalid: StringIndexerHandleInvalid = StringIndexerHandleInvalid.NoFilter | ||
| handleInvalid: StringIndexerHandleInvalid = StringIndexerHandleInvalid.Keep |
tovbinm
reviewed
Aug 27, 2018
|
|
||
| import com.salesforce.op.UID | ||
| import com.salesforce.op.features.types._ | ||
| import com.salesforce.op.stages.impl.feature.StringIndexerHandleInvalid.{Keep, Skip} |
Collaborator
There was a problem hiding this comment.
I think you can do import com.salesforce.op.stages.impl.feature.StringIndexerHandleInvalid._
then assert(Seq(Skip, Error, Keep).contains(value), ...)
tovbinm
approved these changes
Aug 27, 2018
Collaborator
tovbinm
left a comment
tovbinm
left a comment
There was a problem hiding this comment.
some minor comments, otherwise lgtm!
Collaborator
error file=/home/circleci/repo/core/src/main/scala/com/salesforce/op/stages/impl/feature/OpStringIndexer.scala message=File line length exceeds 120 characters line=66 |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 85.61% 86.13% +0.51%
==========================================
Files 292 292
Lines 8761 9519 +758
Branches 308 333 +25
==========================================
+ Hits 7501 8199 +698
- Misses 1260 1320 +60
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
OpStringIndexer fails when NoFilter is set for handle invalid because this value doesnt exist in spark
Describe the proposed solution
Update enum to match spark supported valuese