Improved Coverage for RichDataType#67
Merged
tovbinm merged 5 commits intosalesforce:masterfrom Aug 17, 2018
Merged
Conversation
|
Thanks for the contribution! Before we can merge this, we need @himsmittal to sign the Salesforce.com Contributor License Agreement. |
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 85.79% 85.79%
=======================================
Files 298 298
Lines 9760 9760
Branches 535 535
=======================================
Hits 8374 8374
Misses 1386 1386Continue to review full report at Codecov.
|
tovbinm
approved these changes
Aug 17, 2018
Collaborator
tovbinm
left a comment
tovbinm
left a comment
There was a problem hiding this comment.
lgtm! only one minor comment.
| in(ds) noneOf "f2" should ((x: Double) => x > 3.5) | ||
| } | ||
|
|
||
| it should "only compare types and ignore nullability" in { |
Collaborator
There was a problem hiding this comment.
Minor correction: lets replace it in this test case with Spec(com.salesforce.op.utils.spark.RichDataType.getClass).
Contributor
Author
There was a problem hiding this comment.
Changed usage of "it" to reflect RichDataType.
Thanks
ericwayman
pushed a commit
that referenced
this pull request
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test case for checking nullability for ArrayType , MapType