Make Feature class public instead hide it's ctor#45
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=========================================
+ Coverage 83.47% 83.9% +0.42%
=========================================
Files 296 296
Lines 9380 9679 +299
Branches 344 544 +200
=========================================
+ Hits 7830 8121 +291
- Misses 1550 1558 +8
Continue to review full report at Codecov.
|
leahmcguire
approved these changes
Aug 9, 2018
Collaborator
|
should we make FeatureLike private to avoid confusion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Impossible to change the internal feature fields after creation, e.g response/predictor.
Describe the proposed solution
Making Feature case class public to allow changing feature fields if needed using
.copymethod. For example if one would like to change the type of the feature from response to predictor.We still maintain the ctor as private, enforcing usage of creating features through
FeatureBuilder.Describe alternatives you've considered
None