Fix ModelInsightsTest flakiness due to coefficients turning negative #407
Merged
gerashegalov merged 1 commit intomasterfrom Sep 12, 2019
Merged
Fix ModelInsightsTest flakiness due to coefficients turning negative #407gerashegalov merged 1 commit intomasterfrom
ModelInsightsTest flakiness due to coefficients turning negative #407gerashegalov merged 1 commit intomasterfrom
Conversation
TuanNguyen27
requested review from
Jauntbox,
gerashegalov,
leahmcguire,
tovbinm and
wsuchy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
========================================
Coverage 86.95% 86.95%
========================================
Files 337 337
Lines 11060 11060
Branches 357 591 +234
========================================
Hits 9617 9617
Misses 1443 1443Continue to review full report at Codecov.
|
gerashegalov
changed the title
ModelInsightsTest flakiness due to coefficients turning negative
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModelInsightsTest was flaky due to returned coefficients being negative sometimes.
Describe the proposed solution
Adding absolute value when summing descaled coefficients