Allow customizing serialization for feature generator extract functions#352
Merged
Allow customizing serialization for feature generator extract functions#352
Conversation
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
+ Coverage 86.68% 86.73% +0.05%
==========================================
Files 335 336 +1
Lines 10781 10799 +18
Branches 347 346 -1
==========================================
+ Hits 9345 9367 +22
+ Misses 1436 1432 -4
Continue to review full report at Codecov.
|
michaelweilsalesforce
approved these changes
Jul 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
It's not possible to save a model with a feature generator stage that has an extract function with ctor arguments.
Describe the proposed solution
Allow customizing read/write for extract functions, e.g.
Describe alternatives you've considered
NA