Serialize blacklisted map keys with the model + updated access on workflow/model members#320
Merged
Serialize blacklisted map keys with the model + updated access on workflow/model members#320
Conversation
…kflow/model members
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 86.43% 86.44% +0.01%
==========================================
Files 327 327
Lines 10593 10602 +9
Branches 354 336 -18
==========================================
+ Hits 9156 9165 +9
Misses 1437 1437
Continue to review full report at Codecov.
|
Jauntbox
suggested changes
May 15, 2019
Contributor
Jauntbox
left a comment
Jauntbox
left a comment
There was a problem hiding this comment.
LGTM - one small comment
| * | ||
| * @return raw features for workflow | ||
| */ | ||
| final def getRawFeatures(): Array[OPFeature] = rawFeatures |
| .setStages(wf.getStages()) | ||
| .setFeatures(wf.getResultFeatures()) | ||
| .setParameters(wf.getParameters()) | ||
| .setRawFeatureFilterResults(rawFeatureFilterResults) |
Contributor
There was a problem hiding this comment.
Do we have a getRawFeatureFilterResults()?
Jauntbox
approved these changes
May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
We currently do not serialize backlisted map keys computed in RFF with the model.
Describe the proposed solution
Describe alternatives you've considered
NA