Skip to content

Improvements of Vectorizer tests#291

Merged
wsuchy merged 4 commits intomasterfrom
ks/improved-tests-OPPivotVectorizerTest
Apr 17, 2019
Merged

Improvements of Vectorizer tests#291
wsuchy merged 4 commits intomasterfrom
ks/improved-tests-OPPivotVectorizerTest

Conversation

@wsuchy
Copy link
Copy Markdown
Contributor

@wsuchy wsuchy commented Apr 17, 2019

Yet another tests changes

Copy link
Copy Markdown
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2019

Codecov Report

Merging #291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #291   +/-   ##
======================================
  Coverage    86.4%   86.4%           
======================================
  Files         319     319           
  Lines       10452   10452           
  Branches      346     346           
======================================
  Hits         9031    9031           
  Misses       1421    1421
Impacted Files Coverage Δ
...ce/op/stages/impl/feature/OpOneHotVectorizer.scala 96.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 462226a...63c028c. Read the comment docs.

@wsuchy wsuchy merged commit f228f26 into master Apr 17, 2019
@tovbinm tovbinm deleted the ks/improved-tests-OPPivotVectorizerTest branch April 17, 2019 22:14
@Jauntbox Jauntbox mentioned this pull request May 2, 2019
@salesforce-cla
Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @wsuchy to sign the Salesforce.com Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants