Fix rawPrediction of OpXGBoostClassifcationModel for binary classification#229
Merged
Fix rawPrediction of OpXGBoostClassifcationModel for binary classification#229
Conversation
…lues for binary classification
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 86.41% 86.39% -0.02%
==========================================
Files 312 312
Lines 10182 10183 +1
Branches 333 564 +231
==========================================
- Hits 8799 8798 -1
- Misses 1383 1385 +2
Continue to review full report at Codecov.
|
tovbinm
approved these changes
Feb 19, 2019
|
Hey @tovbinm do you have a plan to release this fix? |
Collaborator
|
Yes, we are planning to make a release within the next few weeks. For now, you can publish from master locally. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
NA
Describe the proposed solution
OpXGBoostClassificationModel outputs only one raw prediction value for binary classification and causes ArrayIndexOutOfBoundsException in BinaryClassificationEvaluator. Modify OpXGBoostClassificationModel to generate two raw prediction values for binary classification.
Describe alternatives you've considered
NA
Additional context
NA