Prevent duplicating comments and tokens when rewriting trait headers#6834
Open
ytmimi wants to merge 8 commits intorust-lang:mainfrom
Open
Prevent duplicating comments and tokens when rewriting trait headers#6834ytmimi wants to merge 8 commits intorust-lang:mainfrom
ytmimi wants to merge 8 commits intorust-lang:mainfrom
Conversation
rustbot
added
the
S-waiting-on-review
Helper method to get the `Span` of a known substring within a span.
Simplify macro header formatting by using the new `HeaderPart::keyword` associated function.
Keep track of the `lo` span when rewriting parts the header so that we can correctly recover comments between the last rewritten part of the trait definition and the body of the trait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6160, Fixes #5841
Expand the
HeaderPartstruct to handle some new header parts like,const,unsafe, andautoand refactortraitheader formatting to useHeaderPart.r? @fee1-dead since you originally added
HeaderPart